Fix ObjC Support iteration #7498
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a changelog entry |
leemaguire
approved these changes
Oct 27, 2021
|
This needs tests which actually test that the bug that the user reported is fixed. |
|
There is a whole suite of tests for using the obj-c API from Swift and this should be tested there, not in an unrelated place. |
|
@tgoyne ptal. |
|
Nevermind, seeing some build failures on CI. |
|
@tgoyne PTAL. |
tgoyne
approved these changes
Nov 30, 2021
| @@ -4,6 +4,9 @@ x.y.z Release notes (yyyy-MM-dd) | |||
| * Conform `@ThreadSafe` and `ThreadSafeReference` to `Sendable`. | |||
|
|
|||
| ### Fixed | |||
| * Fix `RLMCollectionIterator` where `RLMCollectionIterator` contents were not RLMObject. | |||
| This is for users using the optional `RLMSupport.swift` file. | |||
| * Change default request timeout for `RLMApp` from 6 seconds to 60 seconds. | |||
|
What is the status on this? It happens for me as well. |
|
I'm having the same thing over and over again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7490.